Get the App
SLTechnology News&Howtos  ›  IT Information  › 

Linus Torvalds angry: do not submit Linux PR request if there are no comments.

Shulou Source: shulou.com Published: 2023-11-24 14:46:53 11月15日 Update

CTOnews.com February 22 news, Linux 6.3 merger window has been launched recently, Linus Torvalds has received a large number of pull request (PR) requests, on the whole, all the work in this window period has been carried out smoothly.

Linus Torvalds also expressed his views on the problems in the merger window, which CTOnews.com translated as follows:

I received a PR request (5c0f220e1b2d): "merge the 'for-linus / hardening' branch into' for-next / hardening'".

There is only this short line of text for the whole request information.

I have stressed many times before, and now obviously need to emphasize again: if you are too lazy to explain why a merge is needed, then this merge request should be discarded.

This is really a rule that every developer should keep in mind, not just an empty word.

I repeat: if you cannot provide a reasonable explanation or explanation for the merge request, please do not submit it.

It's really that simple. There is absolutely * never * no excuse for merging without explaining why these mergers exist.

In this case, I really think there is no point in merging if there are no comments on the merge request!

If you think there's a reason, please say it! Make the merge submission seem more reasonable.

Because now it seems completely meaningless. I really * hate * meaningless mergers. They only make history look worse and harder to read.

Tags: Meaning interpretation again situation text comments one line people information excuses branches history but only as a whole messages reasons opinions rules Apple Docker Huawei Linux macOS MariaDB Microsoft MySQL NVidia OPPO Reno MySQL Xiaomi Docker Linux Shulou Technology